Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754146AbZIGEvn (ORCPT ); Mon, 7 Sep 2009 00:51:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753308AbZIGEvm (ORCPT ); Mon, 7 Sep 2009 00:51:42 -0400 Received: from e28smtp05.in.ibm.com ([59.145.155.5]:56748 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbZIGEvm (ORCPT ); Mon, 7 Sep 2009 00:51:42 -0400 Date: Mon, 7 Sep 2009 10:21:37 +0530 From: Balbir Singh To: KAMEZAWA Hiroyuki Cc: nishimura@mxp.nes.nec.co.jp, Daisuke Nishimura , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [mmotm][BUGFIX][PATCH] memcg: fix softlimit css refcnt handling(yet another one) Message-ID: <20090907045137.GE8315@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20090903141727.ccde7e91.nishimura@mxp.nes.nec.co.jp> <20090904131835.ac2b8cc8.kamezawa.hiroyu@jp.fujitsu.com> <20090904141157.4640ec1e.nishimura@mxp.nes.nec.co.jp> <20090904142143.15ffcb53.kamezawa.hiroyu@jp.fujitsu.com> <20090904142654.08dd159f.kamezawa.hiroyu@jp.fujitsu.com> <20090904154050.25873aa5.nishimura@mxp.nes.nec.co.jp> <20090904163758.a5604fee.kamezawa.hiroyu@jp.fujitsu.com> <20090904190726.6442f3df.d-nishimura@mtf.biglobe.ne.jp> <20090907080403.5e4510b3.d-nishimura@mtf.biglobe.ne.jp> <20090907094912.5cbbbaa5.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20090907094912.5cbbbaa5.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1876 Lines: 57 * KAMEZAWA Hiroyuki [2009-09-07 09:49:12]: > > From: Daisuke Nishimura > > > > refcount of the "victim" should be decremented before exiting the loop. > > > > Signed-off-by: Daisuke Nishimura > Nice! > > Acked-by: KAMEZAWA Hiroyuki > > > --- > > mm/memcontrol.c | 8 ++++++-- > > 1 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index ac51294..011aba6 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -1133,8 +1133,10 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem, > > * anything, it might because there are > > * no reclaimable pages under this hierarchy > > */ > > - if (!check_soft || !total) > > + if (!check_soft || !total) { > > + css_put(&victim->css); > > break; > > + } > > /* > > * We want to do more targetted reclaim. > > * excess >> 2 is not to excessive so as to > > @@ -1142,8 +1144,10 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem, > > * coming back to reclaim from this cgroup > > */ > > if (total >= (excess >> 2) || > > - (loop > MEM_CGROUP_MAX_RECLAIM_LOOPS)) > > + (loop > MEM_CGROUP_MAX_RECLAIM_LOOPS)) { > > + css_put(&victim->css); > > break; > > + } > > } > > } > > if (!mem_cgroup_local_usage(&victim->stat)) { Good catch! Sorry for the late response I've been away Acked-by: Balbir Singh -- Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/