DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=d0gK+loezf24e/Uv0xl0doCXLEGZGQTp2d2ZM0AmQypADnHbLpmnpGOIga1Fugy10z
         rtH1FfwBwHFAaDlTqO7tdHgrppIuHgmJGMxdjV5yzRnbYSKFHmOm4YRvJ/9Fy62ze397
         jxrSKx9zr98jee0gx6Jagt708CDkQhswPeoC4=
MIME-Version: 1.0
In-Reply-To: <20090727151900.GB4052@pc-ras4041.res.insa>
References: <1246352745-31323-1-git-send-email-albin.tonnerre@free-electrons.com>
	 <20090727162312.35c2f9d4@hskinnemoen-d830>
	 <20090727151900.GB4052@pc-ras4041.res.insa>
Date: Mon, 7 Sep 2009 08:22:06 +0200
Message-ID: <cd73a99e0909062322j683952e6m803dd6b703bf758d@mail.gmail.com>
Subject: Re: [PATCH] Add poll_get_char and poll_put_char uart_ops to 
	atmel_serial.
From: Andrew Victor <avictor.za@gmail.com>
To: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
       linux-kernel@vger.kernel.org, Nicolas Ferre <nicolas.ferre@atmel.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 718
Lines: 27

hi Albin,

Any reason you're not using the register access macro's like the rest
of the driver?

> +       while (!(__raw_readl(aup->uart.membase + ATMEL_US_CSR) & ATMEL_US_RXRDY))

while (!(UART_GET_CSR(..) & ATMEL_US_RXRDY))

> +       return __raw_readl(aup->uart.membase + ATMEL_US_RHR);

return UART_GET_CHAR(..);

> +       __raw_writel(ch, aup->uart.membase + ATMEL_US_THR);

UART_PUT_CHAR(..., ch);


Otherwise the patch looks fine to me.

Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/