Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313AbZIGMbA (ORCPT ); Mon, 7 Sep 2009 08:31:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753131AbZIGMa7 (ORCPT ); Mon, 7 Sep 2009 08:30:59 -0400 Received: from mail.renesas.com ([202.234.163.13]:51594 "EHLO mail04.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753007AbZIGMa6 (ORCPT ); Mon, 7 Sep 2009 08:30:58 -0400 X-AuditID: ac140387-00000006000005fd-97-4aa4fce065f8 Date: Mon, 07 Sep 2009 21:30:23 +0900 From: Hirokazu Takata Subject: Re: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section. In-reply-to: <1252293179-13382-5-git-send-email-tabbott@ksplice.com> To: Tim Abbott Cc: Linux Kernel Mailing List , Sam Ravnborg , Hirokazu Takata Message-id: MIME-version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-type: text/plain; charset=US-ASCII User-Agent: Wanderlust/2.14.0 (Africa) Emacs/22.3 Mule/5.0 (SAKAKI) Renesas-ECN: H07-0010RT References: <1252293179-13382-1-git-send-email-tabbott@ksplice.com> <1252293179-13382-5-git-send-email-tabbott@ksplice.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2344 Lines: 72 From: Tim Abbott Subject: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section. Date: Sun, 06 Sep 2009 23:12:58 -0400 > Since these get squashed into the .data output section by the m32r > linker script, it seems likely that they don't need their own input > sections. > > I'd like an explicit confirmation from Hirokazu Takata that this is > correct (in particular, that there isn't some hidden reason why there > two structures need to be at the start of the .data output section). There is no apparent reason. We've placed them at the start of .data section, because they are for initial stack region. I think it would be better that we place them to .init.data section. Any comment? > This patch is preparation for cleaning up the m32r architecture to use > the new macros in vmlinux.lds.h; if these sections are indeed not > needed, then we can use the RW_DATA_SECTION macro for m32r and save a > bunch of redundant code. > > Signed-off-by: Tim Abbott > Cc: Hirokazu Takata > --- > arch/m32r/kernel/head.S | 4 ++-- > arch/m32r/kernel/vmlinux.lds.S | 2 -- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/m32r/kernel/head.S b/arch/m32r/kernel/head.S > index 0a71944..fc4d769 100644 > --- a/arch/m32r/kernel/head.S > +++ b/arch/m32r/kernel/head.S > @@ -268,13 +268,13 @@ ENTRY(empty_zero_page) > /*------------------------------------------------------------------------ > * Stack area > */ > - .section .spi > + .section .data > ALIGN > .global spi_stack_top > .zero 1024 > spi_stack_top: > > - .section .spu > + .section .data > ALIGN > .global spu_stack_top > .zero 1024 > diff --git a/arch/m32r/kernel/vmlinux.lds.S b/arch/m32r/kernel/vmlinux.lds.S > index eb3e425..1984b9f 100644 > --- a/arch/m32r/kernel/vmlinux.lds.S > +++ b/arch/m32r/kernel/vmlinux.lds.S > @@ -49,8 +49,6 @@ SECTIONS > > /* writeable */ > .data : { /* Data */ > - *(.spu) > - *(.spi) > DATA_DATA > CONSTRUCTORS > } > -- > 1.6.3.3 > -- Takata -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/