Subject: Re: [PATCH 00/12] Gigaset driver patches for 2.6.32
From: Daniel Walker <dwalker@fifo99.com>
To: Tilman Schmidt <tilman@imap.cc>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       i4ldeveloper@listserv.isdn4linux.de, Hansjoerg Lipp <hjlipp@web.de>
In-Reply-To: <4AA4CD64.4070501@imap.cc>
References: <20090906-patch-gigaset-00.tilman@imap.cc>
	 <1252286806.2139.1.camel@desktop>  <4AA4CD64.4070501@imap.cc>
Content-Type: text/plain
Date: Mon, 07 Sep 2009 07:30:55 -0700
Message-Id: <1252333855.2139.15.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1097
Lines: 28

On Mon, 2009-09-07 at 11:07 +0200, Tilman Schmidt wrote:
> Daniel,
> 
> thanks for taking a look at my patches.
> 
> On Sun, 06 Sep 2009 18:26:46 -0700, Daniel Walker wrote:
> > patches 6,7,10, and 12 all have checkpatch errors. Could you fix those? 
> 
> I have reissued patch 7, exchanging the "static" and "inline" keywords
> as requested.
> 
> The other patches I'd much prefer to keep as they are. The "ERRORs"
> checkpatch.pl reported for them are results of keeping to the existing
> formatting of the patched files. Completely reformatting them would
> cloud the actual changes made by the patches.

Yeah, it looks like the whole file needs a checkpatch clean up.. Sounds
like your not willing to do that? Usually if a checkpatch cleanup comes
first prior to all your other changes , it doesn't usually cloud the
rest of the changes..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/