Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583AbZIGOgU (ORCPT ); Mon, 7 Sep 2009 10:36:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753349AbZIGOgT (ORCPT ); Mon, 7 Sep 2009 10:36:19 -0400 Received: from BISCAYNE-ONE-STATION.MIT.EDU ([18.7.7.80]:50948 "EHLO biscayne-one-station.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535AbZIGOgT (ORCPT ); Mon, 7 Sep 2009 10:36:19 -0400 Date: Mon, 7 Sep 2009 10:35:59 -0400 (EDT) From: Tim Abbott X-X-Sender: tabbott@dr-wily.mit.edu To: Hirokazu Takata cc: Linux Kernel Mailing List , Sam Ravnborg Subject: Re: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section. In-Reply-To: Message-ID: References: <1252293179-13382-1-git-send-email-tabbott@ksplice.com> <1252293179-13382-5-git-send-email-tabbott@ksplice.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Flag: NO X-Spam-Score: 0.00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 28 On Mon, 7 Sep 2009, Hirokazu Takata wrote: > From: Tim Abbott > Subject: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section. > Date: Sun, 06 Sep 2009 23:12:58 -0400 > > Since these get squashed into the .data output section by the m32r > > linker script, it seems likely that they don't need their own input > > sections. > > > > I'd like an explicit confirmation from Hirokazu Takata that this is > > correct (in particular, that there isn't some hidden reason why there > > two structures need to be at the start of the .data output section). > > There is no apparent reason. We've placed them at the start of .data > section, because they are for initial stack region. > > I think it would be better that we place them to .init.data section. > Any comment? Assuming that they aren't used after the initial boot process, that's probably the right choice. -Tim Abbott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/