Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbZIGTPz (ORCPT ); Mon, 7 Sep 2009 15:15:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751025AbZIGTPy (ORCPT ); Mon, 7 Sep 2009 15:15:54 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:56195 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbZIGTPx (ORCPT ); Mon, 7 Sep 2009 15:15:53 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4AA55BCF.6080609@s5r6.in-berlin.de> Date: Mon, 07 Sep 2009 21:15:27 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090630 SeaMonkey/1.1.17 MIME-Version: 1.0 To: pageexec@freemail.hu CC: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] firewire: core: reduce stack usage in bus reset tasklet References: , <4AA558DF.5024.3D1AC09D@pageexec.freemail.hu> In-Reply-To: <4AA558DF.5024.3D1AC09D@pageexec.freemail.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1572 Lines: 54 pageexec@freemail.hu wrote: > On 6 Sep 2009 at 18:48, Stefan Richter wrote: > >> Index: linux-2.6.31-rc9/drivers/firewire/core-card.c >> =================================================================== >> --- linux-2.6.31-rc9.orig/drivers/firewire/core-card.c >> +++ linux-2.6.31-rc9/drivers/firewire/core-card.c >> @@ -38,16 +38,21 @@ >> >> #include "core.h" >> >> -int fw_compute_block_crc(u32 *block) >> +int fw_compute_block_crc(u32 *block, gfp_t flags) >> { >> - __be32 be32_block[256]; >> - int i, length; >> + static __be32 *be32_block; > ^^^^^^ > > did you actually mean that to be static? if so, then you might as well allocate the > buffer statically and not worry about a runtime allocation failure. Uh, that's a cut'n'paste mistake. It shouldn't be static. Thanks, I'll correct that before I put it into linux1394-2.6.git. >> + int i, length = (*block >> 16) & 0xff; >> + >> + be32_block = kmalloc(length * 4, flags); >> + if (WARN_ON(!be32_block)) >> + goto out; >> >> - length = (*block >> 16) & 0xff; >> for (i = 0; i < length; i++) >> be32_block[i] = cpu_to_be32(block[i + 1]); >> *block |= crc_itu_t(0, (u8 *) be32_block, length * 4); >> >> + kfree(be32_block); >> + out: >> return length; >> } > > > -- Stefan Richter -=====-==--= =--= --=== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/