Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbZIGVEK (ORCPT ); Mon, 7 Sep 2009 17:04:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752039AbZIGVEJ (ORCPT ); Mon, 7 Sep 2009 17:04:09 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60615 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342AbZIGVEI (ORCPT ); Mon, 7 Sep 2009 17:04:08 -0400 Date: Mon, 7 Sep 2009 14:03:08 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Linux Kernel Mailing List , Al Viro , Linux Filesystem Mailing List cc: Eric Paris , Mimi Zohar , James Morris Subject: [PATCH 3/8] Simplify exec_permission_lite() further In-Reply-To: Message-ID: References: User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 42 From: Linus Torvalds Date: Fri, 28 Aug 2009 10:53:56 -0700 This function is only called for path components that are already known to be directories (they have a '->lookup' method). So don't bother doing that whole S_ISDIR() testing, the whole point of the 'lite()' version is that we know that we are looking at a directory component, and that we're only checking name lookup permission. Signed-off-by: Linus Torvalds --- fs/namei.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index bf8aa95..e39e5cb 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -445,13 +445,7 @@ static int exec_permission_lite(struct inode *inode) if (mode & MAY_EXEC) goto ok; - if ((inode->i_mode & S_IXUGO) && capable(CAP_DAC_OVERRIDE)) - goto ok; - - if (S_ISDIR(inode->i_mode) && capable(CAP_DAC_OVERRIDE)) - goto ok; - - if (S_ISDIR(inode->i_mode) && capable(CAP_DAC_READ_SEARCH)) + if (capable(CAP_DAC_OVERRIDE) || capable(CAP_DAC_READ_SEARCH)) goto ok; return -EACCES; -- 1.6.4.1.209.g74b8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/