Date: Tue, 8 Sep 2009 12:30:39 +0100 (BST)
From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
cc: Andrew Morton <akpm@linux-foundation.org>,
       Hiroaki Wakabayashi <primulaelatior@gmail.com>,
       Lee Schermerhorn <lee.schermerhorn@hp.com>,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Nick Piggin <npiggin@suse.de>, Rik van Riel <riel@redhat.com>,
       linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/8] mm: munlock use follow_page
In-Reply-To: <20090908115825.edb06814.kamezawa.hiroyu@jp.fujitsu.com>
Message-ID: <Pine.LNX.4.64.0909081227010.25652@sister.anvils>
References: <Pine.LNX.4.64.0909072222070.15424@sister.anvils>
 <Pine.LNX.4.64.0909072227140.15430@sister.anvils>
 <20090908115825.edb06814.kamezawa.hiroyu@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1147
Lines: 33

On Tue, 8 Sep 2009, KAMEZAWA Hiroyuki wrote:
> On Mon, 7 Sep 2009 22:29:55 +0100 (BST)
> Hugh Dickins <hugh.dickins@tiscali.co.uk> wrote:
> >  void munlock_vma_pages_range(struct vm_area_struct *vma,
> > -			   unsigned long start, unsigned long end)
> > +			     unsigned long start, unsigned long end)
> >  {
> > +	unsigned long addr;
> > +
> > +	lru_add_drain();
> >  	vma->vm_flags &= ~VM_LOCKED;
> > -	__mlock_vma_pages_range(vma, start, end, 0);
> > +
> > +	for (addr = start; addr < end; addr += PAGE_SIZE) {
> > +		struct page *page = follow_page(vma, addr, FOLL_GET);
> > +		if (page) {
> > +			lock_page(page);
> > +			if (page->mapping)
> > +				munlock_vma_page(page);
> 
> Could you add "please see __mlock_vma_pages_range() to see why" or some here ?

Why the test on page->mapping?
Right, I'll add some such comment on that.
Waiting a day or two to see what else comes up.

Thanks,
Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/