Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455AbZIHSeb (ORCPT ); Tue, 8 Sep 2009 14:34:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752407AbZIHSea (ORCPT ); Tue, 8 Sep 2009 14:34:30 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:45278 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752267AbZIHSe3 (ORCPT ); Tue, 8 Sep 2009 14:34:29 -0400 Date: Tue, 8 Sep 2009 14:34:31 -0400 From: Christoph Hellwig To: Linus Torvalds Cc: Linux Kernel Mailing List , Al Viro , Linux Filesystem Mailing List , Eric Paris , Mimi Zohar , James Morris Subject: Re: [PATCH 8/8] jffs2/jfs/xfs: switch over to 'check_acl' rather than 'permission()' Message-ID: <20090908183431.GA22314@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 19 The split of these patches is a bit odd, either do all in one patch or one patch per filesystem instead of those groups. That beeing said if we go down this way I would prefer if we go down all the way, that is convert the remaining few filesystems that pass a check_acl argument to generic_permission (btrfs, gfs2, ocfs2) and just kill off that argument. After that there is another step we can easily go: as we now cache the ACLs in the generic inode instead of the per-fs one we can move the get_cached_acl call to your acl_permission_check helper (for gfs2/ocfs2 that don't cache ACLs it will always fail), and not call out to the fs for the fast path at all. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/