Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbZIHTGx (ORCPT ); Tue, 8 Sep 2009 15:06:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751830AbZIHTGw (ORCPT ); Tue, 8 Sep 2009 15:06:52 -0400 Received: from verein.lst.de ([213.95.11.210]:55448 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbZIHTGv (ORCPT ); Tue, 8 Sep 2009 15:06:51 -0400 Date: Tue, 8 Sep 2009 21:06:14 +0200 From: Christoph Hellwig To: OGAWA Hirofumi Cc: Zdenek Kabelac , Christoph Hellwig , "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-mmc@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: Regression in suspend to ram in 2.6.31-rc kernels Message-ID: <20090908190614.GA18545@lst.de> References: <200908312119.12121.rjw@sisk.pl> <20090903232317.GA6760@lst.de> <87ljkvmt71.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ljkvmt71.fsf@devron.myhome.or.jp> User-Agent: Mutt/1.3.28i X-Spam-Score: 0 () Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 19 On Fri, Sep 04, 2009 at 09:47:46AM +0900, OGAWA Hirofumi wrote: > Well, that commit seems a bit strange. It calls fat_clusters_flush() > unconditionally without checking sb->s_dirt. However, if my guess is > right, "sync after removed event" itself sounds like the issue in > suspend process. The idea of ->sync_fs is that we always perform the sync activity, and not just the usual background superblock writeback trigerred by s_dirt. If FAT doesn't need that and never has races around s_dirt you can add the check back, but I would recommend against it. Also when you hack around this in FAt MMC will still fail with every other filesystem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/