Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbZIHWUg (ORCPT ); Tue, 8 Sep 2009 18:20:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752310AbZIHWUf (ORCPT ); Tue, 8 Sep 2009 18:20:35 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:39443 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819AbZIHWUe (ORCPT ); Tue, 8 Sep 2009 18:20:34 -0400 Date: Tue, 8 Sep 2009 15:20:36 -0700 From: "Paul E. McKenney" To: Christoph Lameter Cc: Eric Dumazet , Pekka Enberg , Zdenek Kabelac , Patrick McHardy , Robin Holt , Linux Kernel Mailing List , Jesper Dangaard Brouer , Linux Netdev List , Netfilter Developers Subject: Re: [PATCH] slub: fix slab_pad_check() Message-ID: <20090908222036.GM6753@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <4A9FCDC6.3060003@gmail.com> <4A9FDA72.8060001@gmail.com> <4AA00400.1030005@gmail.com> <20090903231757.GP6761@linux.vnet.ibm.com> <20090904204335.GG6751@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 29 On Tue, Sep 08, 2009 at 03:57:04PM -0400, Christoph Lameter wrote: > On Fri, 4 Sep 2009, Paul E. McKenney wrote: > > > We have gotten along fine with only SLAB_DESTROY_BY_RCU for almost > > five years, so I think we are plenty fine with what we have. So, as > > you say, "as the need arises". > > These were the glory years where SLAB_DESTROY_BY_RCU was only used for > anonymous vmas. Now Eric has picked it up for the net subsystem. You may > see the RCU use proliferate. > > The kmem_cache_destroy rcu barriers did not matter until > SLAB_DESTROY_BY_RCU spread. Certainly it is true that increased use of RCU has resulted in new requirements, which have in turn led to any number of changes over the years. Are you saying that people have already asked you for additional variants of SLAB_DESTROY_BY_RCU? If so, please don't keep them a secret! Otherwise, experience indicates that it is best to wait for the new uses, because they usually aren't quite what one might expect. Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/