Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbZIHWXs (ORCPT ); Tue, 8 Sep 2009 18:23:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751922AbZIHWXr (ORCPT ); Tue, 8 Sep 2009 18:23:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26408 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbZIHWXr (ORCPT ); Tue, 8 Sep 2009 18:23:47 -0400 Message-ID: <4AA6D968.6000009@redhat.com> Date: Tue, 08 Sep 2009 18:23:36 -0400 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 2.0.0.17 (X11/20080915) MIME-Version: 1.0 To: Hugh Dickins CC: Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Linus Torvalds , Nick Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/8] mm: fix anonymous dirtying References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 20 Hugh Dickins wrote: > do_anonymous_page() has been wrong to dirty the pte regardless. > If it's not going to mark the pte writable, then it won't help > to mark it dirty here, and clogs up memory with pages which will > need swap instead of being thrown away. Especially wrong if no > overcommit is chosen, and this vma is not yet VM_ACCOUNTed - > we could exceed the limit and OOM despite no overcommit. > > Signed-off-by: Hugh Dickins > Cc: stable@kernel.org Acked-by: Rik van Riel -- All rights reversed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/