Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953AbZIIB0R (ORCPT ); Tue, 8 Sep 2009 21:26:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751651AbZIIB0Q (ORCPT ); Tue, 8 Sep 2009 21:26:16 -0400 Received: from fifo99.com ([67.223.236.141]:55039 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752749AbZIIB0P (ORCPT ); Tue, 8 Sep 2009 21:26:15 -0400 Subject: Re: [PATCH] SCSI driver for VMware's virtual HBA - V4. From: Daniel Walker To: akataria@vmware.com Cc: James Bottomley , Rolf Eike Beer , Brian King , "Chetan.Loke@Emulex.Com" , Matthew Wilcox , Roland Dreier , Bart Van Assche , Robert Love , Randy Dunlap , Mike Christie , "linux-scsi@vger.kernel.org" , LKML , Andrew Morton , pv-drivers@vmware.com In-Reply-To: <1252458903.24914.73.camel@ank32.eng.vmware.com> References: <1252458903.24914.73.camel@ank32.eng.vmware.com> Content-Type: text/plain Date: Tue, 08 Sep 2009 18:26:36 -0700 Message-Id: <1252459596.14793.46.camel@desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 31 On Tue, 2009-09-08 at 18:15 -0700, Alok Kataria wrote: > +typedef struct PVSCSIRingCmpDesc { > + u64 context; > + u64 dataLen; > + u32 senseLen; > + u16 hostStatus; > + u16 scsiStatus; > + u32 _pad[2]; > +} __packed PVSCSIRingCmpDesc; I get a lot of checkpatch warnings due to the typedefs here.. They are usually frowned upon, and it really does make you code look alien .. > +#define PVSCSI_MEM_SPACE_COMMAND_PAGE 0 > +#define PVSCSI_MEM_SPACE_INTR_STATUS_PAGE 1 > +#define PVSCSI_MEM_SPACE_MISC_PAGE 2 > +#define PVSCSI_MEM_SPACE_KICK_IO_PAGE 4 > +#define PVSCSI_MEM_SPACE_MSIX_TABLE_PAGE 6 > +#define PVSCSI_MEM_SPACE_MSIX_PBA_PAGE 7 Why not use an enum for the above? Your using enums in the rest of your code.. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/