Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762AbZIIDVD (ORCPT ); Tue, 8 Sep 2009 23:21:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752279AbZIIDVD (ORCPT ); Tue, 8 Sep 2009 23:21:03 -0400 Received: from fifo99.com ([67.223.236.141]:41441 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbZIIDVB (ORCPT ); Tue, 8 Sep 2009 23:21:01 -0400 Subject: Re: [PATCH v2 2/5] Use new __init_task_data macro in arch init_task.c files. From: Daniel Walker To: Joe Perches Cc: Tim Abbott , Linux Kernel Mailing List , Sam Ravnborg In-Reply-To: <1252465802.28130.9.camel@Joe-Laptop.home> References: <1252464546-26394-1-git-send-email-tabbott@ksplice.com> <1252464546-26394-3-git-send-email-tabbott@ksplice.com> <1252465099.14793.49.camel@desktop> <1252465417.28130.3.camel@Joe-Laptop.home> <1252465625.14793.52.camel@desktop> <1252465802.28130.9.camel@Joe-Laptop.home> Content-Type: text/plain Date: Tue, 08 Sep 2009 20:21:22 -0700 Message-Id: <1252466482.14793.60.camel@desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 28 On Tue, 2009-09-08 at 20:10 -0700, Joe Perches wrote: > On Tue, 2009-09-08 at 20:07 -0700, Daniel Walker wrote: > > On Tue, 2009-09-08 at 20:03 -0700, Joe Perches wrote: > > > On Tue, 2009-09-08 at 19:58 -0700, Daniel Walker wrote: > > > > On Tue, 2009-09-08 at 22:49 -0400, Tim Abbott wrote: > > > > > +union thread_union init_thread_union __init_task_data = > > > > > + { INIT_THREAD_INFO(init_task) }; > > > > All the lines like the above are all producing checkpatch errors.. It > > > > looks like the open brace needs to be up with the equals .. > > > Some checkpatch errors are ignorable. > > > checkpatch output is a guide, not a rule. > > > > Not errors, those aren't usually ignorable .. Warnings, those could be.. > > Shrug. So submit a patch... I would if this was code in the kernel already, but it's not. LKML submission is the process people use to find these types of issues. Issues that should be fixed prior to inclusion, and may have been overlooked.. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/