Date: Wed, 9 Sep 2009 06:46:06 -0400
From: "Youquan,Song" <youquan.song@intel.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Youquan Song <youquan.song@intel.com>, mingo@elte.hu, hpa@zytor.com,
       tglx@linutronix.de, linux-kernel@vger.kernel.org, dwmw2@infradead.org,
       Suresh Siddha <suresh.b.siddha@intel.com>, youqun.song@intel.com
Subject: Re: Fix interrupt remapping hang if interrupt remapping disable in BIOS
Message-ID: <20090909104606.GA10454@youquan-linux.bj.intel.com>
References: <20090907141313.GA26091@youquan-linux.bj.intel.com> <20090907145940.GD5294@lenovo>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090907145940.GD5294@lenovo>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1054
Lines: 37

On Mon, Sep 07, 2009 at 06:59:40PM +0400, Cyrill Gorcunov wrote:
> [Youquan Song - Mon, Sep 07, 2009 at 10:13:13AM -0400]
> ...  
> |  static int disable_intremap;
> |  static __init int setup_nointremap(char *str)
> | @@ -607,9 +608,14 @@ end:
> |  int __init intr_remapping_supported(void)
> |  {
> |  	struct dmar_drhd_unit *drhd;
> | -
> | +	struct acpi_table_dmar *dmar;
> | +
> |  	if (disable_intremap)
> |  		return 0;
> | +
> | +	dmar = (struct acpi_table_dmar *)dmar_tbl;
> | +	if (!(dmar->flags & 0x1))
> | +		return 0;
> |  
> |  	for_each_drhd_unit(drhd) {
> |  		struct intel_iommu *iommu = drhd->iommu;
> 
> Hi Youquan,
> 
> perhaps we could move this test to helper function
> in dmar.c instead of plain external variable test?

Good point. I will update it and send it out soon.

- Youquan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/