Subject: Re: [PATCH 2/2] tracing/events: Add kexec tracepoints
From: Daniel Walker <dwalker@fifo99.com>
To: rostedt@goodmis.org
Cc: Li Zefan <lizf@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>,
       Eric Biederman <ebiederm@xmission.com>
In-Reply-To: <1252496788.27001.0.camel@gandalf.stny.rr.com>
References: <4AA70198.9070500@cn.fujitsu.com>  <4AA701B3.704@cn.fujitsu.com>
	 <1252459241.14793.40.camel@desktop>  <4AA70451.6050307@cn.fujitsu.com>
	 <1252472376.14793.85.camel@desktop>
	 <1252496788.27001.0.camel@gandalf.stny.rr.com>
Content-Type: text/plain
Date: Wed, 09 Sep 2009 07:12:08 -0700
Message-Id: <1252505528.14793.93.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1369
Lines: 37

On Wed, 2009-09-09 at 07:46 -0400, Steven Rostedt wrote:
> On Tue, 2009-09-08 at 21:59 -0700, Daniel Walker wrote:
> > On Wed, 2009-09-09 at 09:26 +0800, Li Zefan wrote:
> > > Daniel Walker wrote:
> > > > On Wed, 2009-09-09 at 09:15 +0800, Li Zefan wrote:
> > > >> +       TP_STRUCT__entry(
> > > >> +               __string(       msg,    msg     )
> > > >> +       ),
> > > > 
> > > > Why the funny spacing here?
> > > > 
> > > 
> > > To make the code better-looking.
> > > 
> > > This is the coding-style we use for the code in
> > > include/trace/events/*.
> > 
> > It's part of Linux right? We already have a coding style ..
> 
> It's a special macro. What are you now, part of the style police?

I'm just like everyone else, someone who asks questions and makes
comments .. By using a different style than what the rest of Linux uses
your putting yourself at a disadvantage since you can't easily use
checkpatch on that code (even the stuff that is compliant) ..

Not to mention people might start sending you clean ups that you maybe
won't accept. You could always modify checkpatch to recognize your
style.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/