Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753383AbZIIQ4u (ORCPT ); Wed, 9 Sep 2009 12:56:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752886AbZIIQ4t (ORCPT ); Wed, 9 Sep 2009 12:56:49 -0400 Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:54703 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbZIIQ4t (ORCPT ); Wed, 9 Sep 2009 12:56:49 -0400 Subject: Re: [PATCH] SCSI driver for VMware's virtual HBA - V4. From: Alok Kataria Reply-To: akataria@vmware.com To: Rolf Eike Beer Cc: Daniel Walker , James Bottomley , Brian King , "Chetan.Loke@Emulex.Com" , Matthew Wilcox , Roland Dreier , Bart Van Assche , Robert Love , Randy Dunlap , Mike Christie , "linux-scsi@vger.kernel.org" , LKML , Andrew Morton , "pv-drivers@vmware.com" In-Reply-To: <200909090754.22778.eike-kernel@sf-tec.de> References: <1252458903.24914.73.camel@ank32.eng.vmware.com> <1252459596.14793.46.camel@desktop> <1252472481.2508.20.camel@ank32.eng.vmware.com> <200909090754.22778.eike-kernel@sf-tec.de> Content-Type: text/plain Organization: VMware INC. Date: Wed, 09 Sep 2009 09:56:52 -0700 Message-Id: <1252515412.16631.6.camel@ank32.eng.vmware.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-8.el5_2.3) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 36 Hi Eike, On Tue, 2009-09-08 at 22:54 -0700, Rolf Eike Beer wrote: > Alok Kataria wrote: > > > +/* Command line parameters */ > > +static int pvscsi_ring_pages = PVSCSI_DEFAULT_NUM_PAGES_PER_RING; > > +static int pvscsi_msg_ring_pages = PVSCSI_DEFAULT_NUM_PAGES_MSG_RING; > > +static int pvscsi_cmd_per_lun = PVSCSI_DEFAULT_QUEUE_DEPTH; > > +static int pvscsi_disable_msi; > > +static int pvscsi_disable_msix; > > +static int pvscsi_use_msg = true; > > Should be bool. Yeah, could be done, though I think I will do this later as an incremental change or piggyback it if something else comes up. > > Do I get annoying? ;) :) Do you want the truth ? ;). Actually its good that the code is being reviewed in so much details. Thanks for your time on this. --Alok > > Eike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/