Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbZIISay (ORCPT ); Wed, 9 Sep 2009 14:30:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753932AbZIISax (ORCPT ); Wed, 9 Sep 2009 14:30:53 -0400 Received: from rcsinet12.oracle.com ([148.87.113.124]:31347 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbZIISax (ORCPT ); Wed, 9 Sep 2009 14:30:53 -0400 Date: Wed, 9 Sep 2009 11:28:02 -0700 From: Joel Becker To: Greg KH Cc: Michael Tokarev , Linux-kernel Subject: Re: [patch 00/48] 2.6.27.32-stable review Message-ID: <20090909182802.GA12456@mail.oracle.com> Mail-Followup-To: Greg KH , Michael Tokarev , Linux-kernel References: <20090909030843.GC10608@suse.de> <20090909073150.44F8C12B5F@gandalf.tls.msk.ru> <20090909132340.GA12391@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090909132340.GA12391@suse.de> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) X-Source-IP: acsmt356.oracle.com [141.146.40.156] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4AA7F452.01F8:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2725 Lines: 57 On Wed, Sep 09, 2009 at 06:23:40AM -0700, Greg KH wrote: > On Wed, Sep 09, 2009 at 11:31:50AM +0400, Michael Tokarev wrote: > > > On Tue, Sep 08, 2009 at 09:47:51AM -0500, Jayson King wrote: > > > > A line from the upstream patch is missing in this patch: > > > > > > > > static int ocfs2_write_cluster(struct address_space *mapping, > > > > u32 phys, unsigned int unwritten, > > > > + unsigned int should_zero, > > > > struct ocfs2_alloc_context *data_ac, > > > > struct ocfs2_alloc_context *meta_ac, > > > > struct ocfs2_write_ctxt *wc, u32 cpos, > > > > loff_t user_pos, unsigned user_len) > > ocfs2-initialize-the-cluster-we-re-writing-to-in-a-non-sparse-extend.patch > > ocfs2-ocfs2_write_begin_nolock-should-handle-len-0.patch > > Neither of which looks like an addon, and only one (the first) > > has references to this "should_zero" variable. > > I thought the second one would solve the problem. > > What happened here, I took the upstream patch, was it incorrect? If so, > was there a patch, also upstream, that fixed this problem? The upstream first patch is e7432675f8ca868a4af365759a8d4c3779a3d922. It has this line. The second patch fixes a bug in the first patch, but the bug is not around this line, it's totally separate. Ok, I'm confused. In linux-2.6-stable.git, the 2.6.30.y branch has this for the diff: http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6-stable.git;a=blobdiff;f=fs/ocfs2/aops.c;h=122fb7978f60f7dde54ac0567f578159900f163b;hp=b2c52b3a1484f1c57c4b098bf9706fe21c186ac0;hb=9baf278cca4043a1312f3a40bf17b979b6238ebc;hpb=8c668814e3e2be7d633447bf6e78237d4cedabb7 It has the correct line. But in 2.6.27.y branch, referencing the same upstream commit, there is this diff: http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6-stable.git;a=blobdiff;f=fs/ocfs2/aops.c;h=50bb561860dfb5ee024e7a992bb4d72bc71f0372;hp=a53da1466277abd843b0117f89df9850423ba92b;hb=8338941200d9188e3c866dd16cc2848754947895;hpb=7e8287379470a7c18153be389c9516e31ae141f3 It is missing the line. I think the cherry-pick for 2.6.27.y got broken. Joel -- "If you are ever in doubt as to whether or not to kiss a pretty girl, give her the benefit of the doubt" -Thomas Carlyle Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/