Date: Thu, 10 Sep 2009 01:10:09 +0100 (IST)
From: Dave Airlie <airlied@linux.ie>
To: Jerome Glisse <jglisse@redhat.com>
cc: airlied@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.sf.net
Subject: Re: [PATCH] drm/radeon/kms: Don't try to process irq when we are
 unloading
In-Reply-To: <1252527787-2203-1-git-send-email-jglisse@redhat.com>
Message-ID: <alpine.DEB.2.00.0909100109190.29694@skynet.skynet.ie>
References: <1252527787-2203-1-git-send-email-jglisse@redhat.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1205
Lines: 37

On Wed, 9 Sep 2009, Jerome Glisse wrote:

> If module is being unloaded we should not try to handle irq especialy
> we should not call into drm helper or we could hard hang the computer
> free_irq will call the irq handler to make sure we behave properly.

Should you not just ack all irqs here before returning, else we'll
just get called again.

Dave.

> 
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>
> ---
>  drivers/gpu/drm/radeon/r100.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
> index 5708c07..36d0ba2 100644
> --- a/drivers/gpu/drm/radeon/r100.c
> +++ b/drivers/gpu/drm/radeon/r100.c
> @@ -319,6 +319,9 @@ int r100_irq_process(struct radeon_device *rdev)
>  	if (!status) {
>  		return IRQ_NONE;
>  	}
> +	if (rdev->shutdown) {
> +		return IRQ_NONE;
> +	}
>  	while (status) {
>  		/* SW interrupt */
>  		if (status & RADEON_SW_INT_TEST) {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/