Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753727AbZIJTuU (ORCPT ); Thu, 10 Sep 2009 15:50:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753598AbZIJTuT (ORCPT ); Thu, 10 Sep 2009 15:50:19 -0400 Received: from brick.kernel.dk ([93.163.65.50]:37373 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbZIJTuT (ORCPT ); Thu, 10 Sep 2009 15:50:19 -0400 Date: Thu, 10 Sep 2009 21:50:21 +0200 From: Jens Axboe To: Ed Cashin Cc: alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org, apw@canonical.com, bonbons@linux-vserver.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] aoe: end barrier bios with EOPNOTSUPP Message-ID: <20090910195021.GW18599@kernel.dk> References: <20090905051735.GH18599@kernel.dk> <366469f19c41e0150028b886f6859019@coraid.com> <20090908193540.GB18599@kernel.dk> <60772f633c524ba873f569966fccd6ce@coraid.com> <20090909180804.3e62331a@lxorguk.ukuu.org.uk> <30b7855d211ab5b6bef6fe2cd9b76295@coraid.com> <20090909205835.GK18599@kernel.dk> <810bbe1723b0a205f9b5018a5ddaa722@coraid.com> <20090910074820.GS18599@kernel.dk> <84f18127dcdb4762bf9dc6796846087f@coraid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84f18127dcdb4762bf9dc6796846087f@coraid.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1269 Lines: 31 On Thu, Sep 10 2009, Ed Cashin wrote: > On Thu Sep 10 03:48:22 EDT 2009, jens.axboe@oracle.com wrote: > > On Wed, Sep 09 2009, Ed Cashin wrote: > ... > > > If I had a reproducable problem case that the barrier implementation > > > could fix, it would be very helpful. > > > > Depending on timing and the other end, it may not be easy to reproduce. > > But the problem is indeed real, so I think you should just add the > > proper barrier implementation instead of spending too much time trying > > to create a reproducable problem. By the time you get there, you could > > have fixed it many times over :-) > > OK. I will start work on it. But if anybody can give me a torture > test that works on aoe devices, I'll be grateful. > > I think the EOPNOTSUPP patch is good for the for-next aoe quilt tree, > while the new barrier support will be good for 2.6.32. .31 is already out, so there's plenty of time to fix it for .32 for real. I don't mind putting in the temporary fix in the mean time, though. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/