From: Arnd Bergmann <arnd@arndb.de>
To: Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC][v6][PATCH 0/9] clone_with_pids() syscall
Date: Fri, 11 Sep 2009 13:50:14 +0200
User-Agent: KMail/1.12.1 (Linux/2.6.31-9-generic; KDE/4.3.1; x86_64; ; )
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
       linux-kernel@vger.kernel.org, Oren Laadan <orenl@cs.columbia.edu>,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       Alexey Dobriyan <adobriyan@gmail.com>,
       Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
       torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu,
       hpa@zytor.com, Nathan Lynch <nathanl@austin.ibm.com>,
       container@us.ibm.com, sukadev@us.ibm.com
References: <20090910060627.GA24343@us.ibm.com> <200909111334.45241.arnd@arndb.de> <1252669205.7126.23.camel@laptop>
In-Reply-To: <1252669205.7126.23.camel@laptop>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <200909111350.15004.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1332
Lines: 30

On Friday 11 September 2009, Peter Zijlstra wrote:
> On Fri, 2009-09-11 at 13:34 +0200, Arnd Bergmann wrote:
> > On Friday 11 September 2009, Peter Zijlstra wrote:
> 
> > > If you then get passed a longer clone_struct than you know about, all is
> > > well IFF the tail is 0, otherwise fail with -E2BIG.
> > > 
> > > If you get passed a short clone_struct, zero out the tail.
> > 
> > I would leave out the size argument. We can put a few reserved fields
> > and flag bits in there for possible extensions, but if we ever run out
> > of these, just define a new syscall.
> 
> Why? If we can avoid this new syscall isn't that nicer?

There is a limit to how much flexibility I would aim for. In the last
fourty years, we needed three revisions of that call (fork, clone,
clone2). By invalid extrapolation, adding room for another extension
should give us at least twenty years ;-)

Also, the flags field basically has the same purpose are the size field,
so we do not need both. In the worst case, you can define one of the
flags to mean 'the structure is now 168 bytes long'.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/