Date: Fri, 11 Sep 2009 09:47:03 -0700
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
       Oren Laadan <orenl@cs.columbia.edu>,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       Alexey Dobriyan <adobriyan@gmail.com>,
       Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
       torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu,
       hpa@zytor.com, Nathan Lynch <nathanl@austin.ibm.com>,
       container@us.ibm.com, sukadev@us.ibm.com
Subject: Re: [RFC][v6][PATCH 0/9] clone_with_pids() syscall
Message-ID: <20090911164703.GA29169@us.ibm.com>
References: <20090910060627.GA24343@us.ibm.com> <1252668148.7126.13.camel@laptop> <200909111334.45241.arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200909111334.45241.arnd@arndb.de>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 843
Lines: 27

| Also, if you're passing a struct, why not put nr_pids in there, and
| replace clone_pid_struct with a simple array? That would give us
| 
| struct clone_struct {
|         u64 flags;
|         u64 child_stack;
|         u32 child_tid;
|         u32 parent_tid;
| 	u32 nr_pids;
| 	u32 reserved1;
| 	u64 reserved2;
| };
| 
| int clone2(struct clone_struct *cs, pid_t *pids);

My only concern with this approach was the extra copy_from_user() in the
common case (i.e when not using the extended features).  I assume the
overhead of copy_from_user() is small enough to be ignored ?

Thanks,

Sukadev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/