Subject: Re: [PATCH] [16/21] HWPOISON: The high level memory error handler
 in the VM v7
From: Daniel Walker <dwalker@fifo99.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: npiggin@suse.de, riel@redhat.com, linux-kernel@vger.kernel.org
In-Reply-To: <20090911193346.GE32562@basil.fritz.box>
References: <20090911848.933193846@firstfloor.org>
	 <20090911184845.38A6EB1758@basil.firstfloor.org>
	 <1252697149.28368.12.camel@desktop>
	 <20090911193346.GE32562@basil.fritz.box>
Content-Type: text/plain
Date: Fri, 11 Sep 2009 12:38:24 -0700
Message-Id: <1252697904.28368.15.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1034
Lines: 30

On Fri, 2009-09-11 at 21:33 +0200, Andi Kleen wrote:
> > The rest of your patches are totally clean, except this one .. It has
> > some warning, but one error in the second ifdef block above ..
> 
> That's intentional, fixing it would require a bare , on a single line
> which would be far uglier what is there today. I refuse to make code
> ugly just to work around checkpatch.pl
> 
> -Andi

Here's the error,

ERROR: space required after that ',' (ctx:ExV)
#1086: FILE: fs/proc/meminfo.c:148:
+               ,atomic_long_read(&mce_bad_pages) << (PAGE_SHIFT - 10)
                ^

I think it just wants a space after the comma .. Couldn't you also break
up these printk's so the two ifdef'ed parts are combined into a single
printk that just adds on to the prior print out?

Daniel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/