Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757198AbZILAiJ (ORCPT ); Fri, 11 Sep 2009 20:38:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752527AbZILAiI (ORCPT ); Fri, 11 Sep 2009 20:38:08 -0400 Received: from avexch1.qlogic.com ([198.70.193.115]:40801 "EHLO avexch1.qlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbZILAiF (ORCPT ); Fri, 11 Sep 2009 20:38:05 -0400 Date: Fri, 11 Sep 2009 17:38:08 -0700 From: Andrew Vasquez To: James Bottomley Cc: Linux SCSI Mailing List , Randy Dunlap , Stephen Rothwell , "linux-next@vger.kernel.org" , LKML , Giridhar Malavali , Ravi Anand , Lalit Chandivade Subject: [PATCHv2] qla2xxx: Correct compilation issues when CONFIG_MOUDLES=n. Message-ID: <20090912003808.GD12098@plap4-2.local> References: <20090907210206.7830ba68.sfr@canb.auug.org.au> <20090907102747.ac6b98ff.randy.dunlap@oracle.com> <20090908182541.GB44157@plap4-2.local> <20090911175341.GH710@plap4-2.local> <1252708951.13282.151.camel@mulgrave.site> <20090912000742.GB12098@plap4-2.local> <20090912001752.GC12098@plap4-2.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090912001752.GC12098@plap4-2.local> Organization: QLogic Corporation User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginalArrivalTime: 12 Sep 2009 00:37:38.0335 (UTC) FILETIME=[3AA652F0:01CA3341] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2202 Lines: 77 Randy Dunlap noted: when CONFIG_MODULES=n: drivers/scsi/qla2xxx/qla_os.c:2685: error: dereferencing pointer to incomplete type in kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, KOBJ_CHANGE, envp); Trigger kobject event on the 'struct device' hanging off the pci_dev. Signed-off-by: Andrew Vasquez --- > On Fri, 11 Sep 2009, Andrew Vasquez wrote: > > > The struct device's kobj from pdev->dev? > > > > My udev-foo is pathetic, so how exactly would that get multiplexed at > > the udev side? > > > > KERNEL=="???", SUBSYSTEM=="???", ACTION=="change", RUN+="qla2xxx_udev.sh" > > Ok, udevadm helps a bit... Let me see if I can convert this uevent > off of: > > kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp); > > to something meaningful: > > UEVENT[1252714722.263731] change > /devices/pci0000:17/0000:17:08.0/0000:1e:00.0 (pci) > ACTION=change > DEVPATH=/devices/pci0000:17/0000:17:08.0/0000:1e:00.0 > SUBSYSTEM=pci > FW_DUMP=6 > DRIVER=qla2xxx > PHYSDEVBUS=pci > PHYSDEVDRIVER=qla2xxx > PCI_CLASS=C0400 > PCI_ID=1077:2532 > PCI_SUBSYS_ID=1077:015C > PCI_SLOT_NAME=0000:1e:00.0 > MODALIAS=pci:v00001077d00002532sv00001077sd0000015Cbc0Csc04i00 > SEQNUM=3574 Ok, with the kobject_uevent_env() change and the udev-rule modified to: SUBSYSTEM=="pci", ENV{DRIVER}="qla2xxx", ACTION=="change", RUN+="qla2xxx_udev.sh" we're working again. This seem reasonable? Thanks, AV diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 29396c0..369a270 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -2683,8 +2683,7 @@ qla2x00_uevent_emit(struct scsi_qla_host *vha, u32 code) /* do nothing */ break; } - kobject_uevent_env(&(&vha->hw->pdev->driver->driver)->owner->mkobj.kobj, - KOBJ_CHANGE, envp); + kobject_uevent_env(&(&vha->hw->pdev->dev)->kobj, KOBJ_CHANGE, envp); } void -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/