Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbZILJrl (ORCPT ); Sat, 12 Sep 2009 05:47:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753309AbZILJrk (ORCPT ); Sat, 12 Sep 2009 05:47:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57415 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbZILJrj (ORCPT ); Sat, 12 Sep 2009 05:47:39 -0400 Subject: Re: [origin tree boot crash] Revert "selinux: clean up avc node cache when disabling selinux" From: Eric Paris To: Ingo Molnar Cc: James Morris , Thomas Liu , linux-kernel@vger.kernel.org, Linus Torvalds In-Reply-To: <20090912072450.GA6767@elte.hu> References: <20090912072450.GA6767@elte.hu> Content-Type: text/plain; charset="UTF-8" Date: Sat, 12 Sep 2009 05:46:31 -0400 Message-Id: <1252748791.2305.89.camel@dhcp231-106.rdu.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 28 On Sat, 2009-09-12 at 09:24 +0200, Ingo Molnar wrote: > James - i did not see a security pull request email from you in my > lkml folder so i created this new thread. -tip testing found the > easy crash below. It reverts cleanly so i went that easy route. > > At a really quick 10-seconds glance the crash happens because we > destroy the slab cache twice, if the sysctl is toggled twice? No, it's only being free'd once (and can only be freed once since the /selinuxfs file disappears when it happens). It's being freed while there are still entries in it. This actually points out to me that SELinux was leaking memory when disabled at run time (not when disabled from the kernel command line) and that's the real problem. I'll take a look at it tonight, James, if you haven't ask Linus to pull can you hold off until I get this long standing memory leak fixed? If Linus already took the change we should revert and do them both again. (This patch is right, just obviously incomplete) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/