Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753642AbZILKoi (ORCPT ); Sat, 12 Sep 2009 06:44:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753530AbZILKoi (ORCPT ); Sat, 12 Sep 2009 06:44:38 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:60706 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524AbZILKoh (ORCPT ); Sat, 12 Sep 2009 06:44:37 -0400 Date: Sat, 12 Sep 2009 12:43:46 +0200 From: Ingo Molnar To: Eric Paris Cc: James Morris , Thomas Liu , linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [origin tree boot crash] Revert "selinux: clean up avc node cache when disabling selinux" Message-ID: <20090912104346.GB27935@elte.hu> References: <20090912072450.GA6767@elte.hu> <1252748791.2305.89.camel@dhcp231-106.rdu.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1252748791.2305.89.camel@dhcp231-106.rdu.redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 32 * Eric Paris wrote: > On Sat, 2009-09-12 at 09:24 +0200, Ingo Molnar wrote: > > James - i did not see a security pull request email from you in my > > lkml folder so i created this new thread. -tip testing found the > > easy crash below. It reverts cleanly so i went that easy route. > > > > At a really quick 10-seconds glance the crash happens because we > > destroy the slab cache twice, if the sysctl is toggled twice? > > No, it's only being free'd once (and can only be freed once since > the /selinuxfs file disappears when it happens). It's being freed > while there are still entries in it. > > This actually points out to me that SELinux was leaking memory > when disabled at run time (not when disabled from the kernel > command line) and that's the real problem. > > I'll take a look at it tonight, James, if you haven't ask Linus to > pull can you hold off until I get this long standing memory leak > fixed? If Linus already took the change we should revert and do > them both again. (This patch is right, just obviously incomplete) FYI, the changes went all upstream yesterday. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/