Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754693AbZIMPtm (ORCPT ); Sun, 13 Sep 2009 11:49:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754372AbZIMPtk (ORCPT ); Sun, 13 Sep 2009 11:49:40 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:50683 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbZIMPtj (ORCPT ); Sun, 13 Sep 2009 11:49:39 -0400 Date: Sun, 13 Sep 2009 17:49:40 +0200 (CEST) From: Julia Lawall To: Atsushi Nemoto Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap In-Reply-To: <20090914.003321.160496287.anemo@mba.ocn.ne.jp> Message-ID: References: <20090913.232548.253168283.anemo@mba.ocn.ne.jp> <20090914.003321.160496287.anemo@mba.ocn.ne.jp> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1695 Lines: 39 On Mon, 14 Sep 2009, Atsushi Nemoto wrote: > On Sun, 13 Sep 2009 17:14:06 +0200 (CEST), Julia Lawall wrote: > > > This patch add some correctness, but obviously incomplete: there are > > > more error pathes without iounmap/kfree/etc. in this function. > > > > The only other error path that I see is: > > > > pdev = platform_device_alloc("leds-gpio", basenum); > > if (!pdev) > > return; > > > > But at that point the call gpiochip_add(&iocled->chip) has already > > succeeded. From looking at this function, I have the impression that it > > makes the iocled structure available from a global array, gpio_desc. > > Since the function containing the above code doesn't return any error > > code, perhaps the caller will not know whether this platform_device_alloc > > error occurred or not. There would also be at least the problem of > > getting the pointer out of the gpio_desc structure. I guess this could be > > done with gpiochip_remove? > > > > I can certainly make a new patch using the goto style, but let me know > > what to do about the above issue. > > Yes, this gpiochip is only used by leds-gpio driver. So > gpiochip_remove() would be the right thing to do when something > failed. > > Also there is one another error path: platform_device_add() failure at > the end of this function. OK, I see. I will submit an improved patch. Thanks for the explanations. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/