Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753448AbZIMW4v (ORCPT ); Sun, 13 Sep 2009 18:56:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753028AbZIMW4u (ORCPT ); Sun, 13 Sep 2009 18:56:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28969 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbZIMW4t (ORCPT ); Sun, 13 Sep 2009 18:56:49 -0400 Subject: Re: [PATCH 1/3] Creds: creds->security can be NULL is selinux is disabled From: Eric Paris To: James Morris Cc: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, sds@tycho.nsa.gov, mingo@elte.hu, dhowells@redhat.com In-Reply-To: References: <20090913025409.6583.58777.stgit@paris.rdu.redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 13 Sep 2009 18:55:41 -0400 Message-Id: <1252882541.16335.1.camel@dhcp231-106.rdu.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 18 On Mon, 2009-09-14 at 08:23 +1000, James Morris wrote: > On Sat, 12 Sep 2009, Eric Paris wrote: > > > __validate_process_creds should check if selinux is actually enabled before > > running tests on the selinux portion of the credentials struct. > > Have you verified that this fixes the problem? Yes, I was able to reproduce the problem using selinux=0 at the command line. This patch fixes the problem. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/