Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266AbZINIjq (ORCPT ); Mon, 14 Sep 2009 04:39:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753551AbZINIjn (ORCPT ); Mon, 14 Sep 2009 04:39:43 -0400 Received: from mail-fx0-f217.google.com ([209.85.220.217]:40321 "EHLO mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbZINIjm convert rfc822-to-8bit (ORCPT ); Mon, 14 Sep 2009 04:39:42 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=UqcDLhETPvlhapED8njf/0xSd4aZZqW5Lb/TXYAVxM72fG2WgPrBlJnzxiJ3EGBRvp u6yLP64+tKhWyqoMXJeAQH61REGbJIpteJoWWt2DXFme2RnVmV3TfsfmlSLlBnQQQmU2 2eSmFUX2nkyCipKseU2W4SqHKnpA0A98iozs4= MIME-Version: 1.0 In-Reply-To: <200909120036.41725.rjw@sisk.pl> References: <20090903232317.GA6760@lst.de> <200909120036.41725.rjw@sisk.pl> Date: Mon, 14 Sep 2009 10:39:44 +0200 Message-ID: Subject: Re: Regression in suspend to ram in 2.6.31-rc kernels From: Zdenek Kabelac To: "Rafael J. Wysocki" Cc: Chris Ball , Pavel Machek , OGAWA Hirofumi , Christoph Hellwig , Linux Kernel Mailing List , linux-mmc@vger.kernel.org, viro@zeniv.linux.org.uk Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 42 2009/9/12 Rafael J. Wysocki : > On Saturday 12 September 2009, Chris Ball wrote: >> Hi, >> >> ? ?> Well system could check basic card ids if they match after resume >> >> No. ?That (arguably) guarantees that it's the same card, but not that >> it wasn't modified in another machine during the suspend. > > Generally speaking, we'd also need to check superblocks for this to work. > >> ? ?> if some users wants to crash his card by randomly swapping it >> ? ?> during suspend/resume - I'd have no problem with that.... >> >> You should have a problem with it. ?Taking a card from a suspended >> machine and working on it with a different machine is not a bizarre >> thing to want to do. > > Agreed. Well - ok - so let me ask this question - if I'll replace local hard drive during suspend - what will happen - is this prohibited by hw (e.i. to switch SATA cables) ? IMHO filesystem should be able to detect corruption of its data structures - (assuming fs is notified about suspend/resume operation) Also there could be one simple quick solution/hack - to require to have at least all remote drives unmounted - so suspend would be refused if it runs mounted card/usb drive - this would be 100% better than current solution which effectively kills my laptop if I forget to unmount card in mmc reader - especially if dmesg contains message with the reason why my suspend fails. Zdenek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/