Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755459AbZINOvT (ORCPT ); Mon, 14 Sep 2009 10:51:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754660AbZINOvS (ORCPT ); Mon, 14 Sep 2009 10:51:18 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48746 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752148AbZINOvR (ORCPT ); Mon, 14 Sep 2009 10:51:17 -0400 Date: Mon, 14 Sep 2009 07:50:47 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Anirban Sinha cc: linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH] cleanup legacy console_print function In-Reply-To: Message-ID: References: <20090825172640.af8b9f58.randy.dunlap@oracle.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 29 On Fri, 11 Sep 2009, Anirban Sinha wrote: > > - console_print(text); \ > - console_print("\n"); \ > + printk(KERN_EMERG "%s", text); \ > + printk(KERN_EMERG "\n"); \ Just clean it up to be printk(KERN_EMERG "%s\n", text); instead while at it. > #define TRACE_CHR(chr) \ > { \ > if(dtlk_trace) \ > - console_print(chr); \ > + printk(KERN_EMERG "%c", chr); \ That can't be right. The translation is to use "%s", not "%c". Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/