DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=svg36bSwrvQhosQAXE/8qOoa7cUu2gm99Vt9J/JSyesu7xgDNbLIYjY1DUtcxC/+p0
         uuth85zdr/FqAhEAXWdUjS5Fkd1mS/BdJVFhWfujWYWO4GsZnqsoLmqypO0FnO39x8VL
         XZBTYyvHrURzsXRU1RLS7elDFOqSlNVmzBUJc=
MIME-Version: 1.0
In-Reply-To: <1252941416.2964.143.camel@localhost.localdomain>
References: <20090804161640.70817ee6.sfr@canb.auug.org.au>
	 <1249403089.4634.139.camel@localhost.localdomain>
	 <20090912165300.9d257283.sfr@canb.auug.org.au>
	 <20090912073906.GA3972@elte.hu> <1252753957.12217.10.camel@ht.satnam>
	 <1252941416.2964.143.camel@localhost.localdomain>
Date: Mon, 14 Sep 2009 10:09:27 -0700
Message-ID: <70318cbf0909141009v46581785m4c70edf31fcb79fa@mail.gmail.com>
Subject: Re: Warning from ring buffer code (Was: Re: linux-next: tip tree 
	build warning)
From: Christopher Li <sparse@chrisli.org>
To: Steven Rostedt <srostedt@redhat.com>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>, Ingo Molnar <mingo@elte.hu>,
       Stephen Rothwell <sfr@canb.auug.org.au>,
       Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
       Peter Zijlstra <peterz@infradead.org>, linux-next@vger.kernel.org,
       linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org,
       Josh Triplett <josh@freedesktop.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 926
Lines: 24

On Mon, Sep 14, 2009 at 8:16 AM, Steven Rostedt <srostedt@redhat.com> wrote:
> static void func(int size_me) {
> ? ? ? ?char array[size_me];
>
> ? ? ? ?memcpy(array, "hello", size);
> };
>
> and sparse failed on it as well. Note, you need to have something call
> func, or sparse will ignore it.

Gcc allows variable size. Sparse expects the size of an array is constant.
For the kernel using variable array size is consider bad. Because the kernel
has very limited stack size. (8K if I remember correctly). Using dynamic array
is very easy to overflow the stack without realizing it.

It deserves a warning. I agree the warning message can use a better description
though.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/