Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042AbZINRwm (ORCPT ); Mon, 14 Sep 2009 13:52:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755667AbZINRwg (ORCPT ); Mon, 14 Sep 2009 13:52:36 -0400 Received: from e24smtp02.br.ibm.com ([32.104.18.86]:33205 "EHLO e24smtp02.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756012AbZINRwd (ORCPT ); Mon, 14 Sep 2009 13:52:33 -0400 Subject: Re: [PATCH] TPM: Fixup pcrs sysfs file From: Rajiv Andrade To: Jason Gunthorpe Cc: James Morris , Andrew Morton , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Debora Velarde , Marcel Selhorst , Jan Beulich In-Reply-To: <1252950328.9372.154.camel@blackbox> References: <20090902031613.GA11464@obsidianresearch.com> <20090903165219.2f79cdc1.akpm@linux-foundation.org> <20090904012818.GU4973@obsidianresearch.com> <20090914062520.GB23467@obsidianresearch.com> <1252950328.9372.154.camel@blackbox> Content-Type: text/plain Date: Mon, 14 Sep 2009 14:52:16 -0300 Message-Id: <1252950736.9372.168.camel@blackbox> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 35 On Mon, 2009-09-14 at 14:45 -0300, Rajiv Andrade wrote: > On Mon, 2009-09-14 at 00:25 -0600, Jason Gunthorpe wrote: > > On Mon, Sep 14, 2009 at 12:36:39PM +1000, James Morris wrote: > > > On Thu, 3 Sep 2009, Jason Gunthorpe wrote: > > > > > > > That sounds like a fairly serious bug, and this looks like a 2.6.31 > > > > > patch. > > > > > > Any comments from the maintainers on this patch? > > > > Sorry for the delay, just reviewed the patches and Jason is right, > Jason's and Andrew's final work (last patch) is great. > > > FWIW, I didn't mention in the patch emails, but all the patches I sent > > fix regressions that have been introduced in the past couple years by > > clean up patches that never tested the code paths they alter. > > > > Hold on, I tested these functions before when submitting them and they > worked fine, and, I couldn't figure it out why yet (only guesses), they > still work for me here, probably due the mishandling of the be32 > formatted value when calling transmit_cmd(). Regardless the testing and what's happening here in my machine, I agree with you both that these fixes should go to 2.6.31. Rajiv -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/