Subject: Re: [PATCH] TPM: Fixup pcrs sysfs file
From: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: James Morris <jmorris@namei.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       Debora Velarde <debora@linux.vnet.ibm.com>,
       Marcel Selhorst <m.selhorst@sirrix.com>,
       Jan Beulich <jbeulich@novell.com>
In-Reply-To: <1252950328.9372.154.camel@blackbox>
References: <20090902031613.GA11464@obsidianresearch.com>
	 <20090903165219.2f79cdc1.akpm@linux-foundation.org>
	 <20090904012818.GU4973@obsidianresearch.com>
	 <alpine.LRH.2.00.0909141236020.28766@tundra.namei.org>
	 <20090914062520.GB23467@obsidianresearch.com>
	 <1252950328.9372.154.camel@blackbox>
Content-Type: text/plain
Date: Mon, 14 Sep 2009 14:52:16 -0300
Message-Id: <1252950736.9372.168.camel@blackbox>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1393
Lines: 35

On Mon, 2009-09-14 at 14:45 -0300, Rajiv Andrade wrote:
> On Mon, 2009-09-14 at 00:25 -0600, Jason Gunthorpe wrote:
> > On Mon, Sep 14, 2009 at 12:36:39PM +1000, James Morris wrote:
> > > On Thu, 3 Sep 2009, Jason Gunthorpe wrote:
> > 
> > > > > That sounds like a fairly serious bug, and this looks like a 2.6.31
> > > > > patch.
> > > 
> > > Any comments from the maintainers on this patch?
> > 
> 
> Sorry for the delay, just reviewed the patches and Jason is right,
> Jason's and Andrew's final work (last patch) is great.
> 
> > FWIW, I didn't mention in the patch emails, but all the patches I sent
> > fix regressions that have been introduced in the past couple years by
> > clean up patches that never tested the code paths they alter.
> > 
> 
> Hold on, I tested these functions before when submitting them and they
> worked fine, and, I couldn't figure it out why yet (only guesses), they
> still work for me here, probably due the mishandling of the be32
> formatted value when calling transmit_cmd().

Regardless the testing and what's happening here in my machine, I agree
with you both that these fixes should go to 2.6.31.

Rajiv


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/