DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=O7tMcdKUfCwynLxODmbG6e8JvJ1AAvvxJJENKReK7PXtJhMHLrr8AajajdDP5FlzSR
         2PAxgTHO3eNRn5kZOmm0V62euJZTQhaIM8vkT/vtegLnTL19DEIb+WvSJBAGp8ehhwyi
         8ItHrp7816MvtdnkWczcx4NQ3aZHFZQ+yaXjI=
MIME-Version: 1.0
In-Reply-To: <1252963292.11643.259.camel@desktop>
References: <1252958896-25150-1-git-send-email-vapier@gentoo.org> 
	<1252961412.11643.215.camel@desktop> <8bd0f97a0909141357y60d7807bm99146d757e6f61da@mail.gmail.com> 
	<1252962263.11643.232.camel@desktop> <8bd0f97a0909141407i26b39f9bq133a62be381601b5@mail.gmail.com> 
	<1252963292.11643.259.camel@desktop>
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Mon, 14 Sep 2009 18:17:25 -0400
Message-ID: <8bd0f97a0909141517i3535bb84j4cbac0cd986d4914@mail.gmail.com>
Subject: Re: [PATCH 00/72] Blackfin updates for 2.6.32
To: Daniel Walker <dwalker@fifo99.com>
Cc: linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2475
Lines: 56

On Mon, Sep 14, 2009 at 17:21, Daniel Walker wrote:
> On Mon, 2009-09-14 at 17:07 -0400, Mike Frysinger wrote:
>> On Mon, Sep 14, 2009 at 17:04, Daniel Walker wrote:
>> > On Mon, 2009-09-14 at 16:57 -0400, Mike Frysinger wrote:
>> >> On Mon, Sep 14, 2009 at 16:50, Daniel Walker wrote:
>> >> > On Mon, 2009-09-14 at 16:07 -0400, Mike Frysinger wrote:
>> >> >> Minor highlights:
>> >> >>  - shadow console to help with really early kernel output
>> >> >>  - proper decoding of double fault handling
>> >> >>
>> >> >> Otherwise, we've got the normal bug fixes, IPIPE updates, and clean ups.
>> >> >>
>> >> >
>> >> > Patches 15, 16, 20, 21, and 61 all have checkpatch errors some with
>> >> > several errors..  Could you clean those up those errors before sending
>> >> > this up stream?
>> >>
>> >> i already checked/reviewed the output in the series
>> >
>> > The remaining problems can be fixed .. Why did you leave those errors ?
>>
>> i'm not going to sweat 80 col warnings when the line is 81 cols with
>> tabs of 8 spaces
>
> The line length ones I'm not worried about, those are just warnings..
>
>> as for the other errors, you probably didnt read the code.  you saw
>> "error" and assumed checkpatch was correct.  it isnt always as it isnt
>> a C parser.
>
> Checkpatch is finding real issues with your patches.. You have
> indentations issues in several of the patches. Your removing good
> formatting and replacing it improper formatting. For instance,
>
> ERROR: code indent should use tabs where possible
> #115: FILE: arch/blackfin/kernel/module.c:102:
> +^I^I           (!strcmp(".bss", shname) &&$
>
> The line your removing had the proper formatting, but this new line has
> improper formatting.. You have several of these issues, you must think
> they aren't important but checkpatch has the WARNING and ERROR
> classification for a reason .. The errors are actual style violation
> that really need to be either cleaned up or explained..
>
> They can be trivially fixed, it's just a matter of adding the proper
> indentation ..

this code i had rewritten and as fallout, the style changed.  looks
fine to me, and no, this particular checpatch "error" is not always
worthwhile (like in this case).
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/