DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=OtCenQCDV2+BsGOdGUhHcT+BR2wHNAxSZvkZ9Irk36Au66XiTQsCnxulasbEPBrEECuEHV6bgHi+qmml1jK9A0WWN0q+JLJXKdmO3gCSZ5zPhLBNDQwD3Q1Xww/fjWCp;
Date: Mon, 14 Sep 2009 17:45:20 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
       Jesse Brandeburg <jesse.brandeburg@gmail.com>
Subject: Re: [PATCH] x86/PCI: initialize PCI bus node numbers early
Message-ID: <20090914174520.7c2b37f5@jbarnes-g45>
In-Reply-To: <4A9D5206.5010603@kernel.org>
References: <20090710104419.0032be7b@jbarnes-g45>
	<20090901135358.GA31282@elte.hu>
	<4A9D5206.5010603@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2051
Lines: 53

On Tue, 01 Sep 2009 09:55:34 -0700
Yinghai Lu <yinghai@kernel.org> wrote:

> Ingo Molnar wrote:
> > * Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > 
> >> The current mp_bus_to_node array is initialized only by AMD
> >> specific code, since AMD platforms have registers that can be used
> >> for determining mode numbers.  On new Intel platforms it's
> >> necessary to initialize this array as well though, otherwise all
> >> PCI node numbers will be 0, when in fact they should be -1
> >> (indicating that I/O isn't tied to any particular node).
> >>
> >> So move the mp_bus_to_node code into the common PCI code, and
> >> initialize it early with a default value of -1.  This may be
> >> overridden later by arch code (e.g. the AMD code).
> >>
> >> With this change, PCI consistent memory and other node specific
> >> allocations (e.g. skbuff allocs) should occur on the "current"
> >> node. If, for performance reasons, applications want to be bound
> >> to specific nodes, they should open their devices only after being
> >> pinned to the CPU where they'll run, for maximum locality.
> >>
> >> Any thoughts here Yinghai or Jesse?
> >>
> >>
> >>  include/asm/pci.h |    2 +
> >>  kernel/setup.c    |    2 +
> >>  pci/amd_bus.c     |   61
> >> +----------------------------------------- pci/common.c      |
> >> 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files
> >> changed, 83 insertions(+), 59 deletions(-)
> > 
> > FYI, this commit:
> > 
> >   acccaba: x86/PCI: initialize PCI bus node numbers early
> > 
> > caused a boot crash in -tip testing:
> > 
> 
> looks like the patch change default 0 in 32bit to -1 ...

Ingo or Yinghai, did you get a chance to try the patch I sent?  Maybe
you've already integrated it...

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/