Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbZIONVu (ORCPT ); Tue, 15 Sep 2009 09:21:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753598AbZIONVt (ORCPT ); Tue, 15 Sep 2009 09:21:49 -0400 Received: from bilbo.ozlabs.org ([203.10.76.25]:40395 "EHLO bilbo.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753349AbZIONVs (ORCPT ); Tue, 15 Sep 2009 09:21:48 -0400 Subject: Re: [PATCH v3 0/3] cpu: pseries: Cpu offline states framework From: Michael Ellerman Reply-To: michael@ellerman.id.au To: Peter Zijlstra Cc: Gautham R Shenoy , linux-kernel@vger.kernel.org, Venkatesh Pallipadi , Arun R Bharadwaj , linuxppc-dev@lists.ozlabs.org, "Darrick J. Wong" In-Reply-To: <1253016701.5506.73.camel@laptop> References: <20090915120629.20523.79019.stgit@sofia.in.ibm.com> <1253016701.5506.73.camel@laptop> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-43Fv+rqidLdZFoOTn47F" Date: Tue, 15 Sep 2009 23:21:51 +1000 Message-Id: <1253020911.16213.24.camel@concordia> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2157 Lines: 64 --=-43Fv+rqidLdZFoOTn47F Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2009-09-15 at 14:11 +0200, Peter Zijlstra wrote: > On Tue, 2009-09-15 at 17:36 +0530, Gautham R Shenoy wrote: > > This patchset contains the offline state driver implemented for > > pSeries. For pSeries, we define three available_hotplug_states. They ar= e: > >=20 > > online: The processor is online. > >=20 > > offline: This is the the default behaviour when the cpu is offl= ined > > even in the absense of this driver. The CPU would call make an > > rtas_stop_self() call and hand over the CPU back to the resourc= e pool, > > thereby effectively deallocating that vCPU from the LPAR. > > NOTE: This would result in a configuration change to the LPAR > > which is visible to the outside world. > >=20 > > inactive: This cedes the vCPU to the hypervisor with a cede lat= ency > > specifier value 2. > > NOTE: This option does not result in a configuration change > > and the vCPU would be still entitled to the LPAR to which it ea= rlier > > belong to. > >=20 > > Any feedback on the patchset will be immensely valuable. >=20 > I still think its a layering violation... its the hypervisor manager > that should be bothered in what state an off-lined cpu is in.=20 Yeah it probably is a layering violation, but when has that stopped us before :) Is it anticipated that this will be useful on platforms other than pseries? cheers --=-43Fv+rqidLdZFoOTn47F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkqvlOwACgkQdSjSd0sB4dIm3gCfXeQEi21cbD6twtUWBS16h2qC mLkAn2SAGoHcs0X6a24MPAt7qF7JgWyM =tBxS -----END PGP SIGNATURE----- --=-43Fv+rqidLdZFoOTn47F-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/