Subject: Re: [PATCH] arm: remove unused code in delay.S
From: Steve Chen <schen@mvista.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
       Russell King - ARM Linux <linux@arm.linux.org.uk>,
       Jamie Lokier <jamie@shareable.org>, linux-kernel@vger.kernel.org,
       Marek Vasut <marek.vasut@gmail.com>, Pavel Machek <pavel@ucw.cz>,
       linux-arm-kernel@lists.infradead.org
In-Reply-To: <m3k4zzdimy.fsf@intrepid.localdomain>
References: <1252875960-21512-1-git-send-email-felipe.contreras@gmail.com>
	 <20090915103739.GA19519@elf.ucw.cz> <1253017761.3273.117.camel@linux-1lbu>
	 <200909151541.08852.marek.vasut@gmail.com>
	 <1253032210.3273.128.camel@linux-1lbu>
	 <94a0d4530909151158y489a96e3x63ff932c713822b0@mail.gmail.com>
	 <1253043875.3273.131.camel@linux-1lbu>
	 <m3k4zzdimy.fsf@intrepid.localdomain>
Content-Type: text/plain
Date: Tue, 15 Sep 2009 17:26:49 -0500
Message-Id: <1253053609.3273.139.camel@linux-1lbu>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1109
Lines: 33

On Tue, 2009-09-15 at 23:04 +0200, Krzysztof Halasa wrote:
> Steve Chen <schen@mvista.com> writes:
> 
> > +config OLD_CPU_DELAY
> > +	depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
> > +	bool "Accurate delays"
> > +	def_bool n
> > +	help
> > +	  Enable if observing longer than expected delays and need more
> > +	  accuracy.  This only applies to older CPUs.
> > +
> 
> If it's that simple then why not enable the extra delay code
> unconditionally when compiling for those CPUs?
> 
> We don't need "do something better" options.

If I know for sure that these are the processors that need that block of
code, your suggestion makes perfect sense.  Unfortunately, I don't know.
My primary goals are

1.  Put a stop to this thread (so far I have failed miserably)
2.  Document that block of code.
3.  If it makes someone's life easier.. it would be a bonus.

Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/