Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbZIOWrj (ORCPT ); Tue, 15 Sep 2009 18:47:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752322AbZIOWrf (ORCPT ); Tue, 15 Sep 2009 18:47:35 -0400 Received: from khc.piap.pl ([195.187.100.11]:59785 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbZIOWre (ORCPT ); Tue, 15 Sep 2009 18:47:34 -0400 From: Krzysztof Halasa To: Steve Chen Cc: Felipe Contreras , Russell King - ARM Linux , Jamie Lokier , linux-kernel@vger.kernel.org, Marek Vasut , Pavel Machek , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm: remove unused code in delay.S References: <1252875960-21512-1-git-send-email-felipe.contreras@gmail.com> <20090915103739.GA19519@elf.ucw.cz> <1253017761.3273.117.camel@linux-1lbu> <200909151541.08852.marek.vasut@gmail.com> <1253032210.3273.128.camel@linux-1lbu> <94a0d4530909151158y489a96e3x63ff932c713822b0@mail.gmail.com> <1253043875.3273.131.camel@linux-1lbu> <1253053609.3273.139.camel@linux-1lbu> Date: Wed, 16 Sep 2009 00:47:34 +0200 In-Reply-To: <1253053609.3273.139.camel@linux-1lbu> (Steve Chen's message of "Tue, 15 Sep 2009 17:26:49 -0500") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 23 Steve Chen writes: > If I know for sure that these are the processors that need that block of > code, your suggestion makes perfect sense. Unfortunately, I don't know. Then I wouldn't write "Accurate delays". "Different", maybe. "Accurate", we don't know. > My primary goals are > > 1. Put a stop to this thread (so far I have failed miserably) > 2. Document that block of code. > 3. If it makes someone's life easier.. it would be a bonus. Uncertain comments don't make life easier. Just write what's certain, or nothing if nothing is. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/