Date: Tue, 15 Sep 2009 23:22:34 -0300
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Richard Purdie <rpurdie@rpsys.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] backlight: Provide two stage registration
Message-ID: <20090916022234.GB1627@khazad-dum.debian.net>
References: <1253031583-11286-1-git-send-email-mjg@redhat.com>
 <1253042322.30165.52.camel@dax.rpnet.com>
 <20090915192730.GA8152@srcf.ucam.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090915192730.GA8152@srcf.ucam.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1085
Lines: 23

On Tue, 15 Sep 2009, Matthew Garrett wrote:
> On Tue, Sep 15, 2009 at 08:18:42PM +0100, Richard Purdie wrote:
> > Could we not pass an optional pointer to a properties structure to
> > create the backlight with instead or find a better way to solve this?
> 
> That'd work, but it'd involve significant refactoring of all the 
> drivers - we really need to be setting max_brightness before 
> device_register() is called. I suspect it'd be an even larger delta 
> against mainline.

rfkill has taught us that if you have parameters that MUST be properly set,
they should be required parameters for the foo_register() call...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/