Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756996AbZIPGwL (ORCPT ); Wed, 16 Sep 2009 02:52:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756193AbZIPGwK (ORCPT ); Wed, 16 Sep 2009 02:52:10 -0400 Received: from gerard.telenet-ops.be ([195.130.132.48]:60365 "EHLO gerard.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbZIPGwJ (ORCPT ); Wed, 16 Sep 2009 02:52:09 -0400 X-Greylist: delayed 300 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Sep 2009 02:52:09 EDT Date: Wed, 16 Sep 2009 08:47:08 +0200 From: Kurt Roeckx To: David Rientjes Cc: "Rafael J. Wysocki" , Dave Jones , LKML , Kernel Testers , Mark Langsdorf , Naga Chumbalkar Subject: Re: [Bug #13780] NULL pointer dereference loading powernowk8 Message-ID: <20090916064708.GA25472@roeckx.be> References: <200909080112.14997.rjw@sisk.pl> <20090908194653.GA3517@roeckx.be> <200909102259.15144.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2032 Lines: 55 On Tue, Sep 15, 2009 at 04:45:37PM -0700, David Rientjes wrote: > On Thu, 10 Sep 2009, Rafael J. Wysocki wrote: > > > > So I did a biset, and this is the result: > > > $ git bisect good > > > 0e64a0c982c06a6b8f5e2a7f29eb108fdf257b2f is first bad commit > > 0e64a0c has this cleanup, which isn't equivalent to the previous code: Please look at the patch I attached to the bug report. There is other code that is not equivalent. It's in comment #17: http://bugzilla.kernel.org/show_bug.cgi?id=13780#c17 And the patch itself: http://bugzilla.kernel.org/attachment.cgi?id=23048 This patch fixes my problem. > @@ -779,11 +834,12 @@ static int powernow_k8_cpu_init_acpi(struct powernow_k8_data *data) > goto err_out; > } > > - if ((data->acpi_data.control_register.space_id != ACPI_ADR_SPACE_FIXED_HARDWARE) || > - (data->acpi_data.status_register.space_id != ACPI_ADR_SPACE_FIXED_HARDWARE)) { > + space_id = data->acpi_data.control_register.space_id; > + if ((space_id != ACPI_ADR_SPACE_FIXED_HARDWARE) || > + (space_id != ACPI_ADR_SPACE_FIXED_HARDWARE)) { > dprintk("Invalid control/status registers (%x - %x)\n", > data->acpi_data.control_register.space_id, > - data->acpi_data.status_register.space_id); > + space_id); > goto err_out; > } > > This got fixed in 2c701b1 in 2.6.31-rc8, so this is most likely the > problem that Kurt was encountering. > > Kurt, could you try 2.6.31 and see if you still experience the issue? If > not, this can be closed. I also noticed this difference (comment #18), patched it, and tried it. This is not the issue. Also note that I tested the 2.6.31-rc9 kernel which still had the problem. The bug report might be a little confusing since after comment #18 there are older mails pasted in the bug report. Kurt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/