Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692AbZIPJyk (ORCPT ); Wed, 16 Sep 2009 05:54:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752703AbZIPJyi (ORCPT ); Wed, 16 Sep 2009 05:54:38 -0400 Received: from 175.210.DSNET ([203.110.175.210]:24675 "EHLO mail.atheros.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752501AbZIPJyh convert rfc822-to-8bit (ORCPT ); Wed, 16 Sep 2009 05:54:37 -0400 From: Jie Yang To: Cyrill Gorcunov , David Miller CC: "dwalker@fifo99.com" , "miles.lane@gmail.com" , "chris.snook@gmail.com" , "jcliburn@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 16 Sep 2009 17:54:38 +0800 Subject: RE: [Patch net-next]atl1e:fix 2.6.31-git4 -- ATL1E 0000:03:00.0: DMA-API: device driver frees DMA Thread-Topic: [Patch net-next]atl1e:fix 2.6.31-git4 -- ATL1E 0000:03:00.0: DMA-API: device driver frees DMA Thread-Index: Aco2s01yB4I9jf6tT8KOTxqrV38rMQAACM1A Message-ID: <72981EBCFD196144B7C6999B9FC34A9A493DE96CFA@SHEXMB-01.global.atheros.com> References: <12530821133392-git-send-email-jie.yang@atheros.com> <1253092251.11643.569.camel@desktop> <20090916.024759.51103835.davem@davemloft.net> <20090916095138.GH5094@lenovo> In-Reply-To: <20090916095138.GH5094@lenovo> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: zh-CN, en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 40 On Wednesday, September 16, 2009 5:52 PM Cyrill Gorcunov wrote: > [David Miller - Wed, Sep 16, 2009 at 02:47:59AM -0700] > | From: Daniel Walker > | Date: Wed, 16 Sep 2009 02:10:51 -0700 > | > | > On Wed, 2009-09-16 at 14:21 +0800, jie.yang@atheros.com wrote: > | >> - pci_unmap_page(pdev, tx_buffer->dma, > | >> + if (tx_buffer->flags & ATL1E_TX_PCIMAP_SINGLE) > | >> + pci_unmap_single(pdev, tx_buffer->dma, > | >> + tx_buffer->length, PCI_DMA_TODEVICE); > | >> + else if (tx_buffer->flags & ATL1E_TX_PCIMAP_PAGE) > | >> + pci_unmap_page(pdev, tx_buffer->dma, > | > > | > Could you run this through checkpatch, and fix any errors > if find? > | > It looks like you uses spaces for tabs in the code above, > maybe in > | > the other block too.. > | > > | > | It's because of his email client, it corrupted the whole patch like > | that. > > well, client seems to be > > | X-Mailer: git-send-email 1.5.2.2 > > more probably the text editor is the reason. > > -- Cyrill > yes, the editor 'vi' have configed "set expandtab". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/