Date: Wed, 16 Sep 2009 10:30:19 -0700 (PDT)
Message-Id: <20090916.103019.253722423.davem@davemloft.net>
To: tabbott@ksplice.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org,
       geofft@ksplice.com
Subject: Re: [PATCH v2] sparc: Clean up linker script using new linker
 script macros.
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.DEB.1.10.0909161322260.2942@dr-wily.mit.edu>
References: <1253119592-19598-2-git-send-email-tabbott@ksplice.com>
	<20090916.101924.186960949.davem@davemloft.net>
	<alpine.DEB.1.10.0909161322260.2942@dr-wily.mit.edu>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1231
Lines: 32

From: Tim Abbott <tabbott@ksplice.com>
Date: Wed, 16 Sep 2009 13:27:43 -0400 (EDT)

> On Wed, 16 Sep 2009, David Miller wrote:
> 
>> Can you do this cleanup without moving the relative locations of .data
>> and .data1 sections?
> 
> Yes, if you just swap RW_DATA_SECTION and .data1 so it looks like
> 
> RW_DATA_SECTION(SMP_CACHE_BYTES, 0, THREAD_SIZE)
> .data1 : {
> 	*(.data1)
> }
> 
> instead, that would preserve their relative locations.
> 
> Currently, switching to RW_DATA_SECTION would still result in a change in 
> their relative position that .data.page_aligned and .data.nosave would be 
> between .data and .data1 (not sure if that is relevant on sparc). (this 
> will change when <http://lkml.org/lkml/2009/9/16/396> is merged).

I don't know which, if any, are relevant or could cause problems.

It's hard for me to ACK this because it's not a straight nop
transformation, which we could at least presume would function
properly if the macros were implemented correctly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/