From: "Gilad Benjamini" <gilad@altornetworks.com>
To: "'Davide Libenzi'" <davidel@xmailserver.org>
Cc: "'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>
References: <023c01ca3724$9f90fcb0$deb2f610$@com> <alpine.DEB.2.00.0909161656150.3124@makko.or.mcafeemobile.com>
In-Reply-To: <alpine.DEB.2.00.0909161656150.3124@makko.or.mcafeemobile.com>
Subject: RE: epoll and closed file descriptors
Date: Wed, 16 Sep 2009 17:23:09 -0700
Message-ID: <024601ca372d$09ad9fb0$1d08df10$@com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: Aco3Kuj0FBkj+IBsRAayZWNoHDSexQAAdHVA
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1651
Lines: 50

Davide wrote:
> On Wed, 16 Sep 2009, Gilad Benjamini wrote:
> 
> > I am running repeatedly into a scenario  where epoll notifies
> userland of
> > events on a closed file descriptor.
> > I am running a single thread application, on a single CPU machine so
> > multiple threads isn't the issue.
> >
> > A sample set of events that I have seen
> > - File descriptor (13) for a socket is closed
> > - epoll_wait returns with no events.
> > - Several epoll related calls happen
> > - More than 20 seconds after the "close", epoll_wait finds an event
> on fd 13
> > with EPOLLIN|EPOLLERR|EPOLLHUP.
> > - epoll_wait continues to report this event
> 
> Epoll removes the fd from its container, when the last instance of the
> underlying kernel file pointer is released (or when you explicitly
> remove it with epoll_ctl(EPOLL_CTL_DEL)).
> If you continue to get the event, it means that someone else has an
> instance of the socket (that, looking at the events, saw a shutdown)
> open,
> by hence keeping the kernel object alive.
> If you don't want to see the events, just remove the socket from the
> epoll
> set before closing.
> Or, you remove the socket the first time you see an EPOLLHUP.
> 
> 
> 
> - Davide

I would, but epoll is preventing me from doing so.
Early in sys_epoll_ctl there are these lines

  file = fget(epfd);
  if (!file)
    goto error_return;

Leaving me in a kind of dead lock

Gilad

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/