Message-ID: <4AB18F8C.1060104@cn.fujitsu.com>
Date: Thu, 17 Sep 2009 09:23:24 +0800
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: mingo@elte.hu, rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stop_machine: disable preempt in stop machine path
References: <4AB0933E.8020901@cn.fujitsu.com> <20090916160358.7faadb5f.akpm@linux-foundation.org>
In-Reply-To: <20090916160358.7faadb5f.akpm@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 31


Andrew Morton wrote:
> On Wed, 16 Sep 2009 15:26:54 +0800
> Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote:
> 
>> We can disable preempt in stop_cpu(), It can reduce the cpu's waiting time
>> and make stop_machine path faster.
>>
> 
> "it can"?  But does it?  Are there any measurements or observations to
> back this up?
> 
> The kstop threads are already created with create_rt_workqueue() (which
> has super-secret undocumented semantics which I have cleverly
> discovered mean "use SCHED_FIFO").
> 

Ah, indeed, please ignore this mail, sorry for bother you all.

Thanks,
Xiao

> So we won't be getting preempted here anyway?
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/