Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476AbZIQJNQ (ORCPT ); Thu, 17 Sep 2009 05:13:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756797AbZIQJNP (ORCPT ); Thu, 17 Sep 2009 05:13:15 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:59867 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756588AbZIQJNP (ORCPT ); Thu, 17 Sep 2009 05:13:15 -0400 Date: Thu, 17 Sep 2009 10:14:41 +0100 From: Alan Cox To: Jason Wessel Cc: Alan Stern , gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] usb console,usb-serial: pass initial console baud on to first tty open Message-ID: <20090917101441.478b3e9b@lxorguk.ukuu.org.uk> In-Reply-To: <4AB1B860.4080105@windriver.com> References: <4AB1B860.4080105@windriver.com> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 17 > It looked like the API for the tty subsystem was gradually changing such > that the ldisc structure could ultimately get shared for use with the > console, but this work is not complete, so we are somewhere in between. The mechanics of this are already there. A tty drive can manage its own termios structs, and the termios structs are pointers in the tty structure > The question is what is an acceptable solution? Take a look at usb_serial.c:serial_install. You can do the console state preservation there and cleanly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/