Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758629AbZIQNHF (ORCPT ); Thu, 17 Sep 2009 09:07:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758550AbZIQNHE (ORCPT ); Thu, 17 Sep 2009 09:07:04 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:41513 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758401AbZIQNHD (ORCPT ); Thu, 17 Sep 2009 09:07:03 -0400 Date: Thu, 17 Sep 2009 14:08:28 +0100 From: Alan Cox To: Jason Wessel Cc: Alan Stern , gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] usb console,usb-serial: pass initial console baud on to first tty open Message-ID: <20090917140828.21341c05@lxorguk.ukuu.org.uk> In-Reply-To: <4AB22892.8000308@windriver.com> References: <4AB1B860.4080105@windriver.com> <20090917101441.478b3e9b@lxorguk.ukuu.org.uk> <4AB22892.8000308@windriver.com> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 552 Lines: 15 > - memset(&dummy, 0, sizeof(struct ktermios)); > - tty->termios = termios; > + tty->termios = &usb_serial_tty_driver->init_termios; That will corrupt the master one which is a reference used for many ports. You need the serial_install stuff or something similar resurrecting to do this properly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/