Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbZIQRMY (ORCPT ); Thu, 17 Sep 2009 13:12:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753102AbZIQRMX (ORCPT ); Thu, 17 Sep 2009 13:12:23 -0400 Received: from mga03.intel.com ([143.182.124.21]:5080 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbZIQRMW (ORCPT ); Thu, 17 Sep 2009 13:12:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,404,1249282800"; d="scan'208";a="188803106" Date: Thu, 17 Sep 2009 10:12:19 -0700 From: Jesse Barnes To: Julia Lawall Cc: kristen.c.accardi@intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 5/10] drivers/pci: Move a dereference below a NULL test Message-ID: <20090917101219.19cb4da1@jbarnes-g45> In-Reply-To: References: X-Mailer: Claws Mail 3.7.2 (GTK+ 2.17.5; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 21 On Sun, 19 Jul 2009 17:26:58 +0200 (CEST) Julia Lawall wrote: > From: Julia Lawall > > If the NULL test is necessary, then the dereference should be moved > below the NULL test. > > The semantic patch that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) Sorry I missed this one. Looks like it's been fixed another way though... -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/