Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755492AbZIRIAb (ORCPT ); Fri, 18 Sep 2009 04:00:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754522AbZIRIA3 (ORCPT ); Fri, 18 Sep 2009 04:00:29 -0400 Received: from mk-filter-4-a-1.mail.uk.tiscali.com ([212.74.100.55]:56639 "EHLO mk-filter-4-a-1.mail.uk.tiscali.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754057AbZIRIA3 (ORCPT ); Fri, 18 Sep 2009 04:00:29 -0400 X-Trace: 259507654/mk-filter-4.mail.uk.tiscali.com/B2C/$b2c-THROTTLED-DYNAMIC/b2c-CUSTOMER-DYNAMIC-IP/80.41.69.67/None/hugh.dickins@tiscali.co.uk X-SBRS: None X-RemoteIP: 80.41.69.67 X-IP-MAIL-FROM: hugh.dickins@tiscali.co.uk X-SMTP-AUTH: X-MUA: X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAFfbskpQKUVD/2dsb2JhbACBUtJuhBwF X-IronPort-AV: E=Sophos;i="4.44,408,1249254000"; d="scan'208";a="259507654" Date: Fri, 18 Sep 2009 08:59:40 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@sister.anvils To: Pekka Enberg cc: Nitin Gupta , Greg KH , Andrew Morton , Ed Tomlinson , linux-kernel , linux-mm , linux-mm-cc , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp Subject: Re: [PATCH 2/4] send callback when swap slot is freed In-Reply-To: <1253260528.4959.13.camel@penberg-laptop> Message-ID: References: <1253227412-24342-1-git-send-email-ngupta@vflare.org> <1253227412-24342-3-git-send-email-ngupta@vflare.org> <1253256805.4959.8.camel@penberg-laptop> <1253260528.4959.13.camel@penberg-laptop> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 17 On Fri, 18 Sep 2009, Pekka Enberg wrote: > > The *hook* looks OK to me but set_swap_free_notify() looks like an ugly > hack. I don't understand why we're setting up the hook lazily in > ramzswap_read() nor do I understand why we need to look up struct > swap_info_struct with a bdev. Surely there's a cleaner way to do all > this? Probably somewhere in sys_swapon()? Sounds like you have something in mind, may well be better, but please show us a patch... (my mind is elsewhere!) Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/