Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbZIROcE (ORCPT ); Fri, 18 Sep 2009 10:32:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751893AbZIROcD (ORCPT ); Fri, 18 Sep 2009 10:32:03 -0400 Received: from cantor.suse.de ([195.135.220.2]:58239 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbZIROcC (ORCPT ); Fri, 18 Sep 2009 10:32:02 -0400 Date: Fri, 18 Sep 2009 16:32:04 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@wotan.suse.de To: Jon Ringle Cc: "Ben Dooks (embedded platforms)" , linux-kernel@vger.kernel.org, Jean Delvare Subject: Re: [PATCH] i2c: Move i2c request_irq so that it occurs after iop3xx_i2c_enable In-Reply-To: <1253281871-28243-1-git-send-email-jon@ringle.org> Message-ID: References: <1253281871-28243-1-git-send-email-jon@ringle.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1906 Lines: 63 On Fri, 18 Sep 2009, Jon Ringle wrote: > If there is a pending i2c interrupt present before i2c-iop3xx initialization > then it must be cleared first before registering irq handler. Otherwise, > a hung system due to an unhandled interrupt loop may occur. Hi Jon, this doesn't really qualify for trivial tree. I am adding Jean Delvare to CC. > Signed-off-by: Jon Ringle > > --- > drivers/i2c/busses/i2c-iop3xx.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-iop3xx.c b/drivers/i2c/busses/i2c-iop3xx.c > index a75c75e..e6dc46d 100644 > --- a/drivers/i2c/busses/i2c-iop3xx.c > +++ b/drivers/i2c/busses/i2c-iop3xx.c > @@ -471,14 +471,6 @@ iop3xx_i2c_probe(struct platform_device *pdev) > ret = -ENXIO; > goto unmap; > } > - ret = request_irq(irq, iop3xx_i2c_irq_handler, 0, > - pdev->name, adapter_data); > - > - if (ret) { > - ret = -EIO; > - goto unmap; > - } > - > memcpy(new_adapter->name, pdev->name, strlen(pdev->name)); > new_adapter->owner = THIS_MODULE; > new_adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD; > @@ -497,6 +489,14 @@ iop3xx_i2c_probe(struct platform_device *pdev) > iop3xx_i2c_reset(adapter_data); > iop3xx_i2c_enable(adapter_data); > > + ret = request_irq(irq, iop3xx_i2c_irq_handler, 0, > + pdev->name, adapter_data); > + > + if (ret) { > + ret = -EIO; > + goto unmap; > + } > + > platform_set_drvdata(pdev, new_adapter); > new_adapter->algo_data = adapter_data; > > -- > tg: (74fca6a..) t/isc-31/i2c-request_irq-iop3xx_i2c_enable-reorder (depends on: b2.6.31.y) > -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/