Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755902AbZIRRBZ (ORCPT ); Fri, 18 Sep 2009 13:01:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752250AbZIRRBY (ORCPT ); Fri, 18 Sep 2009 13:01:24 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:41483 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751879AbZIRRBX (ORCPT ); Fri, 18 Sep 2009 13:01:23 -0400 Subject: Re: [PATCH tip/core/rcu 2/3] Apply results of code inspection of kernel/rcutree_plugin.h From: Peter Zijlstra To: Daniel Walker Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu In-Reply-To: <1253293100.7060.46.camel@desktop> References: <20090918164955.GA22272@linux.vnet.ibm.com> <12532926201851-git-send-email-> <1253293100.7060.46.camel@desktop> Content-Type: text/plain Date: Fri, 18 Sep 2009 19:00:55 +0200 Message-Id: <1253293255.10538.27.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1401 Lines: 34 On Fri, 2009-09-18 at 09:58 -0700, Daniel Walker wrote: > On Fri, 2009-09-18 at 09:50 -0700, Paul E. McKenney wrote: > > > diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h > > index 2b996c3..a2d586c 100644 > > --- a/kernel/rcutree_plugin.h > > +++ b/kernel/rcutree_plugin.h > > @@ -117,9 +117,9 @@ static void rcu_preempt_note_context_switch(int cpu) > > * on line! > > */ > > WARN_ON_ONCE((rdp->grpmask & rnp->qsmaskinit) == 0); > > - phase = !(rnp->qsmask & rdp->grpmask) ^ (rnp->gpnum & 0x1); > > + WARN_ON_ONCE(!list_empty(&t->rcu_node_entry)); > > + phase = (rnp->gpnum + !(rnp->qsmask & rdp->grpmask)) & 0x1; > > list_add(&t->rcu_node_entry, &rnp->blocked_tasks[phase]); > > - smp_mb(); /* Ensure later ctxt swtch seen after above. */ > > spin_unlock_irqrestore(&rnp->lock, flags); > > } > > ERROR: code indent should use tabs where possible > #149: FILE: kernel/rcutree_plugin.h:120: > +^I ^IWARN_ON_ONCE(!list_empty(&t->rcu_node_entry));$ > > > One funny indent in the line above.. If your intending for Ingo to take > this he might just fix it on apply .. Daniel, seriously, get a new hobby. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/