Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756906AbZIRRIV (ORCPT ); Fri, 18 Sep 2009 13:08:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753820AbZIRRIU (ORCPT ); Fri, 18 Sep 2009 13:08:20 -0400 Received: from fifo99.com ([67.223.236.141]:35336 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbZIRRIT (ORCPT ); Fri, 18 Sep 2009 13:08:19 -0400 Subject: Re: [PATCH tip/core/rcu 2/3] Apply results of code inspection of kernel/rcutree_plugin.h From: Daniel Walker To: Peter Zijlstra Cc: lkml In-Reply-To: <1253293490.10538.28.camel@laptop> References: <20090918164955.GA22272@linux.vnet.ibm.com> <12532926201851-git-send-email-> <1253293100.7060.46.camel@desktop> <1253293255.10538.27.camel@laptop> <1253293408.7060.47.camel@desktop> <1253293490.10538.28.camel@laptop> Content-Type: text/plain Date: Fri, 18 Sep 2009 10:08:30 -0700 Message-Id: <1253293710.7060.48.camel@desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 29 On Fri, 2009-09-18 at 19:04 +0200, Peter Zijlstra wrote: > On Fri, 2009-09-18 at 10:03 -0700, Daniel Walker wrote: > > > > > ERROR: code indent should use tabs where possible > > > > #149: FILE: kernel/rcutree_plugin.h:120: > > > > +^I ^IWARN_ON_ONCE(!list_empty(&t->rcu_node_entry));$ > > > > > > > > > > > > One funny indent in the line above.. If your intending for Ingo to take > > > > this he might just fix it on apply .. > > > > > > Daniel, seriously, get a new hobby. > > > > > > I don't get why your so annoyed .. > > If we thought a checkpatch bot was a good idea, we'd have asked the list > admins for one. Who is "we" in the sentence above? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/